[Mesa-dev] [PATCH 09/13] i965: Always create the batch with the batch object in the first execobject slot

[Kenneth Graunke]

On Wednesday, July 19, 2017 3:09:17 AM PDT Chris Wilson wrote:
> Even if we are using older kernels that do not accept the batch in the
> first slot, we can simplify our code by creating the batch with itself
> in the first slot and moving it to the end on execbuf submission.
> ---
>  src/mesa/drivers/dri/i965/intel_batchbuffer.c | 70 ++++++++++++---------------
>  1 file changed, 31 insertions(+), 39 deletions(-)

Alternatively, instead of swapping them out, we could simply add_exec_bo the
batch at the end, and in execbuffer() do:

if (!use_batch_first) {
   execbuf.buffers_ptr++;
   execbuf.buffers_count--;
}

to skip over the batchbuffer entry at the beginning.  That seems easier...

It might make sense to just take this approach right away, effectively
squashing patches 8 and 9...

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170719/edc16e42/attachment.sig>