[Mesa-dev] [PATCH 1/2] mesa: remove pointless assignments in init_teximage_fields_ms()

Ian Romanick idr at freedesktop.org
Thu Jul 20 23:34:42 UTC 2017


This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 07/20/2017 10:07 AM, Brian Paul wrote:
> The NumSamples and FixedSampleLocation fields are set again later at
> the end of the function so these earlier assignments aren't needed.
> ---
>  src/mesa/main/teximage.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index c30f8ac..d55d9b0 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -813,9 +813,6 @@ init_teximage_fields_ms(struct gl_context *ctx,
>     img->Width2 = width - 2 * border;   /* == 1 << img->WidthLog2; */
>     img->WidthLog2 = _mesa_logbase2(img->Width2);
>  
> -   img->NumSamples = 0;
> -   img->FixedSampleLocations = GL_TRUE;
> -
>     switch(target) {
>     case GL_TEXTURE_1D:
>     case GL_TEXTURE_BUFFER:
> 



More information about the mesa-dev mailing list