[Mesa-dev] [PATCH] etnaviv: Avoid duplicates in formats table

[Lucas Stach]

Am Freitag, den 21.07.2017, 15:14 +0200 schrieb Wladimir J. van der
Laan:
> On Fri, Jul 21, 2017 at 02:43:11PM +0200, Lucas Stach wrote:
> > Am Freitag, den 21.07.2017, 12:49 +0200 schrieb Wladimir J. van der
> > Laan:
> > > Remove the following duplicates from the formats table:
> > > 
> > > - R8G8B8A8_UNORM (V_,_T)
> > > - R8G8B8X8_UNORM (_T,_T)
> > > - DXT3_RGBA (_T,_T)
> > > 
> > > Only the first has an effect because the _T overrides the V_ initializer,
> > > the latter two were harmless duplications of the same.
> > 
> > Urgh, well spotted. Has this caused issues in any application?
> 
> > > -   V_(R8G8B8A8_UNORM,   UNSIGNED_BYTE, A8B8G8R8),
> > > -   _T(R8G8B8A8_UNORM, A8B8G8R8, SWIZ(X, Y, Z, W), A8B8G8R8),
> > > +   VT(R8G8B8A8_UNORM,   UNSIGNED_BYTE, A8B8G8R8, SWIZ(X, Y, Z, W), A8B8G8R8),
> 
> Nope, I haven't seen any difference with or without this patch.
> 
> Which is surprising to me, as R8G8B8A8_UNORM vertex format is commonly used for
> per-vertex coloring. But it's possible Mesa accomodates somehow if this
> format is missing.

Yes, probably it converting the vertex format when uploading. Either
way, this fix is straight-forward enough, so I've just pushed it.

Regards,
Lucas