[Mesa-dev] [Mesa-stable] [PATCH 3/3] swr: use the correct variable for no undefined symbols

Rowley, Timothy O timothy.o.rowley at intel.com
Fri Jul 21 19:52:28 UTC 2017


Reviewed-by: Tim Rowley <timothy.o.rowley at intel.com>

> On Jul 21, 2017, at 1:05 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> 
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> The variable name was missing a leading LD_, which resulted in the
> backend binaries having unresolved symbols.
> 
> With the link addressed with earlier patches, we can correct the typo.
> 
> Thanks to Laurent for the help spotting this.
> 
> v2: Split from a larger patch.
> 
> Cc: mesa-stable at lists.freedesktop.org
> Cc: Bruce Cherniak <bruce.cherniak at intel.com>
> Cc: Tim Rowley <timothy.o.rowley at intel.com>
> Cc: Laurent Carlier <lordheavym at gmail.com>
> Fixes: 9475251145174882b532 "swr: standardize linkage and check for
>                             unresolved symbols"
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> Reported-by: Laurent Carlier <lordheavym at gmail.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> src/gallium/drivers/swr/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am
> index bc7abad06af..05fc3b3595b 100644
> --- a/src/gallium/drivers/swr/Makefile.am
> +++ b/src/gallium/drivers/swr/Makefile.am
> @@ -238,7 +238,7 @@ COMMON_LDFLAGS = \
> 	-module \
> 	-no-undefined \
> 	$(GC_SECTIONS) \
> -	$(NO_UNDEFINED)
> +	$(LD_NO_UNDEFINED)
> 
> lib_LTLIBRARIES =
> 
> -- 
> 2.13.0
> 
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable



More information about the mesa-dev mailing list