[Mesa-dev] [PATCH 2/2] anv/blorp: Assert isl_surf_init success in do_buffer_copy

Jason Ekstrand jason at jlekstrand.net
Sat Jul 22 00:20:07 UTC 2017


---
 src/intel/vulkan/anv_blorp.c | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 1492802..eca7a7e 100644
--- a/src/intel/vulkan/anv_blorp.c
+++ b/src/intel/vulkan/anv_blorp.c
@@ -554,20 +554,22 @@ do_buffer_copy(struct blorp_batch *batch,
     */
    enum isl_format format = isl_format_for_size(block_size);
 
+   UNUSED bool ok;
    struct isl_surf surf;
-   isl_surf_init(&device->isl_dev, &surf,
-                 .dim = ISL_SURF_DIM_2D,
-                 .format = format,
-                 .width = width,
-                 .height = height,
-                 .depth = 1,
-                 .levels = 1,
-                 .array_len = 1,
-                 .samples = 1,
-                 .row_pitch = width * block_size,
-                 .usage = ISL_SURF_USAGE_TEXTURE_BIT |
-                          ISL_SURF_USAGE_RENDER_TARGET_BIT,
-                 .tiling_flags = ISL_TILING_LINEAR_BIT);
+   ok = isl_surf_init(&device->isl_dev, &surf,
+                      .dim = ISL_SURF_DIM_2D,
+                      .format = format,
+                      .width = width,
+                      .height = height,
+                      .depth = 1,
+                      .levels = 1,
+                      .array_len = 1,
+                      .samples = 1,
+                      .row_pitch = width * block_size,
+                      .usage = ISL_SURF_USAGE_TEXTURE_BIT |
+                               ISL_SURF_USAGE_RENDER_TARGET_BIT,
+                      .tiling_flags = ISL_TILING_LINEAR_BIT);
+   assert(ok);
 
    struct blorp_surf src_blorp_surf = {
       .surf = &surf,
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list