[Mesa-dev] [PATCH 1/3] egl/wayland: Ignore invalid modifiers

Daniel Stone daniel at fooishbar.org
Mon Jul 24 11:50:05 UTC 2017


On 24 July 2017 at 12:46, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 24 July 2017 at 12:22, Daniel Stone <daniel at fooishbar.org> wrote:
>> It's divergent inside Gallium, where resource_create_with_modifiers
>> will be called rather than resource_create if modifiers != NULL.
>>
> Excuse my ignorance, I must be having a really stupid moment.
> What does Gallium has to do here?
>
> Having a skim trough gallium - there's two ways we can get into
> resource_create_with_modifiers.
>  - createImage - dri2_create_image explicitly passes zero to both
> storage and count
>  - createImageWithModifiers - cannot be called since num_modifiers being zero

Hm, right you are. Never mind, then. Will drop and push.

Cheers,
Daniel


More information about the mesa-dev mailing list