[Mesa-dev] [PATCH 2/3] st/dri2: Return invalid modifier when no driver support

[Daniel Stone]

On 24 July 2017 at 13:09, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 24 July 2017 at 12:44, Daniel Stone <daniel at fooishbar.org> wrote:
>>> AFAICT that will make the check in 1/3 unreachable, yet still nice to have.
>>
>> I don't really see how? 1/3 is for when we have zwp_linux_dmabuf_v1
>> support in the Wayland compositor, but it fails to advertise any
>> modifiers for the formats we're interested in.
>>
> I was under the impression that cannot happen. Perhaps it can ...
> silly me, making assumptions.

Since the 'modifier' event is implicitly used to advertise formats,
Weston will send (format, DRM_FORMAT_MOD_INVALID) for every supported
format, if it cannot query available modifiers.

Cheers,
Daniel