[Mesa-dev] [PATCH] radeon/vcn: move message buffer to vram for now

[Michel Dänzer]

On 25/07/17 02:54 AM, Leo Liu wrote:
> To workaround an unknown bug.
> 
> Signed-off-by: Leo Liu <leo.liu at amd.com>
> ---
>  src/gallium/drivers/radeon/radeon_vcn_dec.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c b/src/gallium/drivers/radeon/radeon_vcn_dec.c
> index bd93b849db..a60b969a27 100644
> --- a/src/gallium/drivers/radeon/radeon_vcn_dec.c
> +++ b/src/gallium/drivers/radeon/radeon_vcn_dec.c
> @@ -1237,8 +1237,9 @@ struct pipe_video_codec *radeon_create_decoder(struct pipe_context *context,
>  		unsigned msg_fb_it_size = FB_BUFFER_OFFSET + FB_BUFFER_SIZE;
>  		if (have_it(dec))
>  			msg_fb_it_size += IT_SCALING_TABLE_SIZE;
> +		/* use vram to improve performance, workaround an unknown bug */
>  		if (!rvid_create_buffer(dec->screen, &dec->msg_fb_it_buffers[i],
> -					msg_fb_it_size, PIPE_USAGE_STAGING)) {
> +					msg_fb_it_size, PIPE_USAGE_DEFAULT)) {
>  			RVID_ERR("Can't allocated message buffers.\n");
>  			goto error;
>  		}
> 

Does PIPE_USAGE_STREAM help as well? That would be system memory but
with write-combined CPU access, whereas PIPE_USAGE_STAGING is cacheable.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer