[Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

[Emil Velikov]

On 25 July 2017 at 03:46, Chih-Wei Huang <cwhuang at android-x86.org> wrote:
> On Tue 11 Jul 2017, Rob Herring wrote:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> Add support for 32-bit RGBX/RGBA formats which are required for Android.
>>>
>>> The original patch (commit ccdcf91104a5) was reverted (commit
>>> c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based
>>> on further investigation by Chad Versace, moving the RGBX/RGBA configs
>>> to the end is enough to prevent breaking GLX.
>>>
>>> The handling of RGBA/RGBX in dri_fill_st_visual is a fix from Marek
>>> Olšák.
>>>
>>> Cc: Eric Anholt <eric at anholt.net>
>>> Cc: Chad Versace <chadversary at chromium.org>
>>> Cc: Mauro Rossi <issor.oruam at gmail.com>
>>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>>> Signed-off-by: Rob Herring <robh at kernel.org>
>>> ---
>>> v2:
>>> - Incorporated dri_fill_st_visual RGBA/X handling from Marek
>>> - Handle RGBA/X in dri2_drawable_get_buffers for completeness
>
> Hi Rob,
> I'm testing this patch with your gbm_gralloc and mesa 17.1.5.
> Before applying this patch, the SurfaceFlinger sees
> the alpha=8 in RenderEngine::chooseEglConfig()
>
May want to check for patches in the Android EGL (meta) library.
I think, in does/did have a handful of workarounds.

Is the Android-x86 one in sync with the one RobH uses?

If there's some problems, I'd check that first.

-Emil