[Mesa-dev] [PATCH 4/6] st/dri: use correct __DRI2_CONFIG_QUERY extension

Marek Olšák maraeo at gmail.com
Tue Jul 25 17:27:57 UTC 2017


Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Fri, Jul 7, 2017 at 8:47 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> If device supports robustness (AKA PIPE_CAP_DEVICE_RESET_STATUS_QUERY)
> then we're using dri_robust_screen_extensions.
> Hence for such cases the DRI loader was not able to query the driver
> options.
>
> This went unnoticed since only r600/radeonsi drivers have the feature.
> At the same time neither of them has a local option that the loader
> cares about.
>
> Fixes: ff2978b4494 ("st/dri: Allow dri users to query also driver
> options")
> Cc: Thomas Hellstrom <thellstrom at vmware.com>
> Cc: Marek Olšák <marek.olsak at amd.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Perhaps we might want to use it in swrast? If so we'll need to move the
> extension to dri_extensions.[ch] first.
> ---
>  src/gallium/state_trackers/dri/dri2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c
> index 60ec38d8e44..6a977636ea8 100644
> --- a/src/gallium/state_trackers/dri/dri2.c
> +++ b/src/gallium/state_trackers/dri/dri2.c
> @@ -1995,7 +1995,7 @@ static const __DRIextension *dri_robust_screen_extensions[] = {
>     &dri2FlushExtension.base,
>     &dri2ImageExtension.base,
>     &dri2RendererQueryExtension.base,
> -   &dri2ConfigQueryExtension.base,
> +   &dri2GalliumConfigQueryExtension.base,
>     &dri2ThrottleExtension.base,
>     &dri2FenceExtension.base,
>     &dri2InteropExtension.base,
> --
> 2.13.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list