[Mesa-dev] [PATCH] mesa: init more msaa fields

Roland Scheidegger sroland at vmware.com
Thu Jul 27 18:38:53 UTC 2017


Am 27.07.2017 um 19:12 schrieb Brian Paul:
> The default values for GL_SAMPLE_SHADING and GL_MIN_SAMPLE_SHADING_VALUE
> are missing from the state tables in the GL spec, but they're supposed
> to be GL_FALSE and 0.0, per the GL_ARB_sample_shading spec.
> 
> Add code for that, just to be explicit.
> ---
>  src/mesa/main/multisample.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c
> index 38d91f7..7821596 100644
> --- a/src/mesa/main/multisample.c
> +++ b/src/mesa/main/multisample.c
> @@ -67,6 +67,8 @@ _mesa_init_multisample(struct gl_context *ctx)
>     ctx->Multisample.SampleCoverage = GL_FALSE;
>     ctx->Multisample.SampleCoverageValue = 1.0;
>     ctx->Multisample.SampleCoverageInvert = GL_FALSE;
> +   ctx->Multisample.SampleShading = GL_FALSE;
> +   ctx->Multisample.MinSampleShadingValue = 0.0f;
>  
>     /* ARB_texture_multisample / GL3.2 additions */
>     ctx->Multisample.SampleMask = GL_FALSE;
> 

Reviewed-by: Roland Scheidegger <sroland at vmware.com>



More information about the mesa-dev mailing list