[Mesa-dev] [PATCH 0/8 v2] A few clover fixes for both CTS and eventual 1.2 support

Aaron Watry awatry at gmail.com
Mon Jul 31 01:26:04 UTC 2017


I've dropped the first patch of the previous series for now. I'm not
withdrawing it completely, just going to see if there's anything about
the user_ptr stuff that could have been causing the issue instead, and
if I'm using too big a hammer in this patch. If I convince myself of its
correctness, it'll be back.

The rest of the patches move the device version declaration to core/device
and then use that along with the -cl-std option to determine which
OpenCL language version to enable in clang.

I've done a full piglit run (again) before/after, and there are no changes
for me on radeonsi/pitcairn if the device is left at CL 1.1.

When I bump my platform/device versions to 1.2, the clang instance has
been confirmed to enable 1.2 language features (like the static keyword
required in test/cl/program/execute/static.cl, which goes skip->pass).

Major changes since v1:
  Addressed Pierre's build-breakage comments
  Added a check for cl-std > device_clc_version
  Added a patch to pass the device object down into invocation.cpp
    instead of adding a bunch of device-based arguments.
  Use device_clc_version for cl version detection instead of device_version
  Added device_clc_version in device.cpp/hpp

Anyway, happy reviewing.

Cc: Jan Vesely <jan.vesely at rutgers.edu>
Cc: Pierre Moreau <pierre.morrow at free.fr>



More information about the mesa-dev mailing list