[Mesa-dev] [PATCH 1/1] gallium, clover: Wait for requested operation if blocking flag is set

[Aaron Watry]

What's here is:
Reviewed-By: Aaron Watry <awatry at gmail.com>

That being said, are clEnqueueMapBuffer/clEnqueueMapImage still
affected or are those always done as blocking operations and my c++ is
weak?

--Aaron

On Fri, Jul 28, 2017 at 10:36 PM, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
> Found by inspection. Fixes clRetain/clRelease event piglit on Turks, no
> regressions.
>
>  src/gallium/state_trackers/clover/api/transfer.cpp | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/src/gallium/state_trackers/clover/api/transfer.cpp b/src/gallium/state_trackers/clover/api/transfer.cpp
> index f7046253be..2af28b1e94 100644
> --- a/src/gallium/state_trackers/clover/api/transfer.cpp
> +++ b/src/gallium/state_trackers/clover/api/transfer.cpp
> @@ -295,6 +295,9 @@ clEnqueueReadBuffer(cl_command_queue d_q, cl_mem d_mem, cl_bool blocking,
>                     &mem, obj_origin, obj_pitch,
>                     region));
>
> +   if (blocking)
> +       hev().wait();
> +
>     ret_object(rd_ev, hev);
>     return CL_SUCCESS;
>
> @@ -325,6 +328,9 @@ clEnqueueWriteBuffer(cl_command_queue d_q, cl_mem d_mem, cl_bool blocking,
>                     ptr, {}, obj_pitch,
>                     region));
>
> +   if (blocking)
> +       hev().wait();
> +
>     ret_object(rd_ev, hev);
>     return CL_SUCCESS;
>
> @@ -362,6 +368,9 @@ clEnqueueReadBufferRect(cl_command_queue d_q, cl_mem d_mem, cl_bool blocking,
>                     &mem, obj_origin, obj_pitch,
>                     region));
>
> +   if (blocking)
> +       hev().wait();
> +
>     ret_object(rd_ev, hev);
>     return CL_SUCCESS;
>
> @@ -399,6 +408,9 @@ clEnqueueWriteBufferRect(cl_command_queue d_q, cl_mem d_mem, cl_bool blocking,
>                     ptr, host_origin, host_pitch,
>                     region));
>
> +   if (blocking)
> +       hev().wait();
> +
>     ret_object(rd_ev, hev);
>     return CL_SUCCESS;
>
> @@ -504,6 +516,9 @@ clEnqueueReadImage(cl_command_queue d_q, cl_mem d_mem, cl_bool blocking,
>                     &img, src_origin, src_pitch,
>                     region));
>
> +   if (blocking)
> +       hev().wait();
> +
>     ret_object(rd_ev, hev);
>     return CL_SUCCESS;
>
> @@ -538,6 +553,9 @@ clEnqueueWriteImage(cl_command_queue d_q, cl_mem d_mem, cl_bool blocking,
>                     ptr, {}, src_pitch,
>                     region));
>
> +   if (blocking)
> +       hev().wait();
> +
>     ret_object(rd_ev, hev);
>     return CL_SUCCESS;
>
> --
> 2.13.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev