[Mesa-dev] [PATCH] mesa/st: fix conditional jump depends on uninitialised value

Karol Herbst karolherbst at gmail.com
Mon Jul 31 14:07:58 UTC 2017


On Mon, Jul 31, 2017 at 2:48 PM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
> Reported by valgrind at:
> glsl_to_tgsi_visitor::visit(ir_expression*) (st_glsl_to_tgsi.cpp:1560)
>
> When compiling the Deus Ex shaders.
>
> Cc: Karol Herbst <karolherbst at gmail.com>
> Cc: Nicolai Hähnle <nicolai.haehnle at amd.com>
> ---
>
>  There is probably more to this. I didn't look too hard.
>

might be. I guess I will take a deeper look in case there is indeed
something else.

Reviewed-by: Karol Herbst <karolherbst at gmail.com>

>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index 0d0eceb312..f22ee18504 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> @@ -4637,20 +4637,21 @@ glsl_to_tgsi_visitor::glsl_to_tgsi_visitor()
>     num_address_regs = 0;
>     samplers_used = 0;
>     images_used = 0;
>     indirect_addr_consts = false;
>     wpos_transform_const = -1;
>     glsl_version = 0;
>     native_integers = false;
>     mem_ctx = ralloc_context(NULL);
>     ctx = NULL;
>     prog = NULL;
> +   precise = 0;
>     shader_program = NULL;
>     shader = NULL;
>     options = NULL;
>     have_sqrt = false;
>     have_fma = false;
>     use_shared_memory = false;
>     has_tex_txf_lz = false;
>     variables = NULL;
>  }
>
> --
> 2.13.3
>


More information about the mesa-dev mailing list