[Mesa-dev] [PATCH] util/rand_xor: add missing include statements

[Eric Engestrom]

On Thursday, 2017-06-01 16:15:41 +0200, Nicolas Dechesne wrote:
> On Thu, Jun 1, 2017 at 3:27 PM, Eric Engestrom
> <eric.engestrom at imgtec.com> wrote:
> > On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote:
> >> Fixes for:
> >>
> >> src/util/rand_xor.c:60:13: error: implicit declaration of function 'open' [-Werror=implicit-function-declaration]
> >>     int fd = open("/dev/urandom", O_RDONLY);
> >>              ^~~~
> >> src/util/rand_xor.c:60:34: error: 'O_RDONLY' undeclared (first use in this function)
> >>     int fd = open("/dev/urandom", O_RDONLY);
> >>                                   ^~~~~~~~
> >>
> >> Signed-off-by: Nicolas Dechesne <nicolas.dechesne at linaro.org>
> >
> > Thanks, r-b and pushed, and welcome to Mesa :)
> 
> thanks , starting small ;)
> 
> I would like this patch on the 17.1 branch as well. Is that possible?
> I actually found the issue on 17.1.1 release.

Actually, since this is a fix, I made a mistake: I should have marked
the commit that broke it with the `Fixes:` tag, before pushing it.

In this case:
Fixes: dd00a3c923ba94986efb ("util/rand_xor: add function to seed rand")

This would have automatically nominated the patch for any branch that
includes the offending commit (and is still maintained).

That said, even after the patch has been pushed, it is still possible to
nominate it for a stable branch; see:
https://www.mesa3d.org/submittingpatches.html#nominations

I've Bcc'ed this email to mesa-stable@, so this should be taken care of
now. (Bcc to avoid replies cluttering that ML.)

For reference, the commit on master is:
adadadc151fa8232ecd7 ("util/rand_xor: add missing include statements")

Cheers,
  Eric