[Mesa-dev] [PATCH] automake: Link all libGL.so variants with -Bsymbolic.

[Brian Paul]

On 06/01/2017 09:46 AM, Jose Fonseca wrote:
> We were linking src/glx with -Bsymbolic, but not the classic/gallium X11
> libGL.so.
>
> But it's always a good idea to build all libGL.so and all DRI drivers
> with -Bsymbolic, otherwise they might resolve symbols from the 3rd party
> application executable or shared libraries, which is _never_ what we
> want.
>
> In particular, this can happen when intercepting OpenGL calls with
> apitrace, before
> https://github.com/apitrace/apitrace/commit/63194b2573176ef34efce1a5c8b08e624b8dddf5
>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>   src/gallium/targets/libgl-xlib/Makefile.am | 1 +
>   src/mesa/drivers/x11/Makefile.am           | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/src/gallium/targets/libgl-xlib/Makefile.am b/src/gallium/targets/libgl-xlib/Makefile.am
> index d3a781848e..a29199fe78 100644
> --- a/src/gallium/targets/libgl-xlib/Makefile.am
> +++ b/src/gallium/targets/libgl-xlib/Makefile.am
> @@ -52,6 +52,7 @@ lib at GL_LIB@_la_SOURCES = xlib.c
>   lib at GL_LIB@_la_LDFLAGS = \
>   	-no-undefined \
>   	-version-number $(GL_MAJOR):$(GL_MINOR):$(GL_TINY) \
> +	$(BSYMBOLIC) \
>   	$(GC_SECTIONS) \
>   	$(LD_NO_UNDEFINED)
>
> diff --git a/src/mesa/drivers/x11/Makefile.am b/src/mesa/drivers/x11/Makefile.am
> index 8c6b67d6a8..6e123ba1b3 100644
> --- a/src/mesa/drivers/x11/Makefile.am
> +++ b/src/mesa/drivers/x11/Makefile.am
> @@ -74,6 +74,7 @@ lib at GL_LIB@_la_LIBADD = \
>   lib at GL_LIB@_la_LDFLAGS = \
>   	-no-undefined \
>   	-version-number $(GL_MAJOR):$(GL_MINOR):$(GL_PATCH) \
> +	$(BSYMBOLIC) \
>   	$(GC_SECTIONS) \
>   	$(LD_NO_UNDEFINED)
>
>

LGTM.

Reviewed-by: Brian Paul <brianp at vmware.com>