[Mesa-dev] [PATCH 04/30] i965/miptree: Store fast clear colors in an isl_color_value

[Chad Versace]

On Fri 26 May 2017, Jason Ekstrand wrote:
> This commit, out of necessity, makes a number of changes at once:
> 
>  1) Changes intel_mipmap_tree to store the clear color for both color
>     and depth as an isl_color_value.
> 
>  2) Changes the depth/stencil emit code to do the format conversion of
>     the depth clear value on Haswell and earlier instead of pulling a
>     uint32_t directly from the miptree.
> 
>  3) Changes ISL's depth/stencil emit code to perform the format
>     conversion of the depth clear value on Haswell and earlier instead
>     of assuming that the depth value in the float is pre-converted.
> 
>  4) Changes blorp to pass the depth value through as a float.
> ---
>  src/intel/blorp/blorp_genX_exec.h                |  2 +-
>  src/intel/isl/isl_emit_depth_stencil.c           | 19 ++++++++
>  src/mesa/drivers/dri/i965/brw_blorp.c            | 18 +++-----
>  src/mesa/drivers/dri/i965/brw_clear.c            | 15 ++-----
>  src/mesa/drivers/dri/i965/brw_meta_util.c        | 56 +++++++-----------------
>  src/mesa/drivers/dri/i965/brw_meta_util.h        |  7 +--
>  src/mesa/drivers/dri/i965/brw_misc_state.c       | 23 +++++++++-
>  src/mesa/drivers/dri/i965/brw_state.h            |  3 ++
>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c |  2 +-
>  src/mesa/drivers/dri/i965/gen6_depth_state.c     |  7 ++-
>  src/mesa/drivers/dri/i965/gen7_misc_state.c      |  7 ++-
>  src/mesa/drivers/dri/i965/gen8_depth_state.c     |  2 +-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c    | 31 -------------
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h    | 34 ++------------
>  14 files changed, 90 insertions(+), 136 deletions(-)

Patch 4 is
Reviewed-by: Chad Versace <chadversary at chromium.org>