[Mesa-dev] [PATCH 06/30] i965/miptree: Refactor intel_miptree_resolve_color

[Chad Versace]

On Wed 31 May 2017, Jason Ekstrand wrote:
> On Tue, May 30, 2017 at 12:40 AM, Pohjolainen, Topi <[1]
> topi.pohjolainen at gmail.com> wrote:
> 
>     On Fri, May 26, 2017 at 04:30:10PM -0700, Jason Ekstrand wrote:
>     > The new version now takes a range of levels as well as a range of
>     > layers.  It should also be a tiny bit faster because it only walks the
>     > resolve_map list once instead of once per layer.
>     > ---
>     >  src/mesa/drivers/dri/i965/brw_blorp.c         |  3 +-
>     >  src/mesa/drivers/dri/i965/brw_context.c       |  9 +++---
>     >  src/mesa/drivers/dri/i965/brw_draw.c          |  2 +-
>     >  src/mesa/drivers/dri/i965/intel_blit.c        |  8 ++---
>     >  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 46


>     Original (a dozen lines earlier) checked for num_layers. Maybe:
> 
>              /* Mipmapped fast clear is only supported for gen8+. */
> 
>     > +      assert(brw->gen >= 8 || map->level == 0);
> 
> 
> Actually, I think I want "assert(brw->gen >= 8 || (map->level == 0 && map->
> layer == 0))"

Which is what appears in wip/i965-resolve-rework-v3. The patch in that
branch is
Reviewed-by: Chad Versace <chadversary at chromium.org>