[Mesa-dev] [PATCH 08/30] i965: Inline renderbuffer_att_set_needs_depth_resolve

Chad Versace chadversary at chromium.org
Tue Jun 6 19:34:05 UTC 2017


On Fri 02 Jun 2017, Jason Ekstrand wrote:
> On Fri, Jun 2, 2017 at 2:41 PM, Chad Versace <[1]chadversary at chromium.org>
> wrote:
> 
>     I believe you could simplify this by eliminating the 'else' branch. As
>     long as depth_irb->layer_count == 1 for non-layered renderbuffers (and
>     I really hope it is), then the 'for' loop does the right thing.
> 
> 
> Sure.  I was sort-of trying to avoid functional changes.  That said... I'm
> happy to make the change.  Lots of stuff would suddenly get cleaner.  Mind if
> that's a follow-on patch to the series?

It was just a suggestion, a nice-to-have.

This patch is
Reviewed-by: Chad Versace <chadversary at chromium.org>


More information about the mesa-dev mailing list