[Mesa-dev] [PATCH] util: make set's deleted_key_value declaration consistent with hash table one

Nicolai Hähnle nhaehnle at gmail.com
Thu Jun 8 07:36:38 UTC 2017


On 30.05.2017 01:51, Vlad Golovkin wrote:
> This also silences following clang warnings:
> no previous extern declaration for non-static variable 'deleted_key' [-Werror,-Wmissing-variable-declarations]
> const void *deleted_key = &deleted_key_value;
>              ^
> no previous extern declaration for non-static variable 'deleted_key_value'
>        [-Werror,-Wmissing-variable-declarations]
> uint32_t deleted_key_value;
>           ^

R-b and pushed, thanks!


> ---
>   src/util/set.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/util/set.c b/src/util/set.c
> index 99abefd063..3925066395 100644
> --- a/src/util/set.c
> +++ b/src/util/set.c
> @@ -45,8 +45,8 @@
>    * free to avoid exponential performance degradation as the hash table fills
>    */
>   
> -uint32_t deleted_key_value;
> -const void *deleted_key = &deleted_key_value;
> +static const uint32_t deleted_key_value;
> +static const void *deleted_key = &deleted_key_value;
>   
>   static const struct {
>      uint32_t max_entries, size, rehash;
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list