[Mesa-dev] [PATCH] Android: vulkan: fix build error due to extra )

[Tapani Pälli]

On 06/08/2017 11:03 AM, Alex Smith wrote:
> Oops, sorry about that!

my bad, for me it actually compiles fine even with the ')' but there is 
maybe some differences between mine and Rob's way of building Mesa


> Alex
> 
> On 8 June 2017 at 03:00, Rob Herring <robh at kernel.org 
> <mailto:robh at kernel.org>> wrote:
> 
>     Commit 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
>     src/vulkan/util") broke the Android build with the following error:
> 
>     build/core/binary.mk:1427 <http://binary.mk:1427>: error:
>     external/mesa3d/src/vulkan/Android.mk: libmesa_vulkan_util: Unused
>     source files: util/vk_util.h).
> 
>     Fixes: 621b3410f5f8 ("util/vulkan: Move Vulkan utilities to
>     src/vulkan/util")
>     Cc: Tapani Pälli <tapani.palli at intel.com
>     <mailto:tapani.palli at intel.com>>
>     Cc: Alex Smith <asmith at feralinteractive.com
>     <mailto:asmith at feralinteractive.com>>
>     Signed-off-by: Rob Herring <robh at kernel.org <mailto:robh at kernel.org>>
>     ---
>       src/vulkan/Android.mk | 2 +-
>       1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/src/vulkan/Android.mk b/src/vulkan/Android.mk
>     index 8eb42ece8786..e19a33dd4f9f 100644
>     --- a/src/vulkan/Android.mk
>     +++ b/src/vulkan/Android.mk
>     @@ -41,7 +41,7 @@ LOCAL_C_INCLUDES := \
>       LOCAL_GENERATED_SOURCES := $(addprefix $(intermediates)/, \
>              $(VULKAN_UTIL_GENERATED_FILES))
> 
>     -LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES))
>     +LOCAL_SRC_FILES := $(VULKAN_UTIL_FILES)
> 
>       vulkan_api_xml = $(MESA_TOP)/src/vulkan/registry/vk.xml
> 
>     --
>     2.11.0
> 
>