[Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

[Emil Velikov]

Hi Gurchetan,

On 9 June 2017 at 01:28, gurchetansingh at chromium.org
<gurchetansingh at chromium.org> wrote:
> From: Gurchetan Singh <gurchetansingh at google.com>
>
> Otherwise, this extension is not visible to the EGL user
> ---
>  src/egl/drivers/dri2/egl_dri2.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
> index 7175e827c9..9e845e99e3 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c
> @@ -429,6 +429,7 @@ static const struct dri2_extension_match swrast_driver_extensions[] = {
>
>  static const struct dri2_extension_match swrast_core_extensions[] = {
>     { __DRI_TEX_BUFFER, 2, offsetof(struct dri2_egl_display, tex_buffer) },
> +   { __DRI_IMAGE, 1, offsetof(struct dri2_egl_display, image) },
IIRC the current codebase will not use it even, we expose it. Correct?
Wild guess here is that you guys have some extra patches around, like
say using vgem? Is there a public repo with the lot?

On the st/dri side (earlier patches) - one should be able to build
st/dri without any hardware specific knowledge and/or files.
Currently that's done by isolating all the DRM specifics in dri2.c.
Not sure if breaking that, architectural split imho, is a good idea.

-Emil