[Mesa-dev] [PATCH v5] egl/android: support for EGL_KHR_partial_update

Eric Engestrom eric.engestrom at imgtec.com
Fri Jun 9 15:29:50 UTC 2017


On Friday, 2017-06-09 20:13:34 +0530, Harish Krupo wrote:
> This patch adds support for the EGL_KHR_partial_update extension for
> android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update.
> 1 test not supported.
> 
> v2: add fallback for eglSetDamageRegionKHR (Tapani)
> 
> v3: The native_window_set_surface_damage call is available only from
>     Android version 6.0. Reintroduce the ANDROID_VERSION guard and
>     advertise extension only if version is >= 6.0. (Emil Velikov)
> 
> v4: use newly introduced ANDROID_API_LEVEL guard rather than
>     ANDROID_VERSION guard to advertise the extension.The extension
>     is advertised only if ANDROID_API_LEVEL >= 23 (Android 6.0 or
>     greater). Add fallback function for platforms other than Android.
>     Fix possible math overflow. (Emil Velikov)
>     Return immediately when n_rects is 0. Place function's entrypoint
>     in alphabetical order. (Eric Engestrom)
> 
> v5: Replace unnecessary calloc with malloc (Eric)
>     Check for BAD_ALLOC error (Emil)
>     Check for error in native_window_set_damage_region. (Emil, Tapani,
>     Eric).
> 
> Signed-off-by: Harish Krupo <harish.krupo.kps at intel.com>
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

Looks good to me.
Do you want me to push this for you?


More information about the mesa-dev mailing list