[Mesa-dev] [PATCH 16/17] ac: enable the AMDGPU asm parser

Nicolai Hähnle nhaehnle at gmail.com
Mon Jun 12 09:26:46 UTC 2017


On 10.06.2017 01:50, Connor Abbott wrote:
> From: Connor Abbott <cwabbott0 at gmail.com>
> 
> Ported from radeonsi. Needed for emitting optimization barriers, which
> contain inline asm.
> 
> Signed-off-by: Connor Abbott <cwabbott0 at gmail.com>
> ---
>   src/amd/common/ac_llvm_util.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c
> index e20456e..0b795ef 100644
> --- a/src/amd/common/ac_llvm_util.c
> +++ b/src/amd/common/ac_llvm_util.c
> @@ -40,6 +40,10 @@ static void ac_init_llvm_target()
>   	LLVMInitializeAMDGPUTargetMC();
>   	LLVMInitializeAMDGPUAsmPrinter();
>   
> +

Extra space.

With that fixed, patches 15 & 16:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>


> +	/* For inline assembly. */
> +	LLVMInitializeAMDGPUAsmParser();
> +
>   	/*
>   	 * Workaround for bug in llvm 4.0 that causes image intrinsics
>   	 * to disappear.
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list