[Mesa-dev] [PATCH 05/11] i965: Remove some of the remnants of meta

Samuel Iglesias Gonsálvez siglesias at igalia.com
Mon Jun 12 11:54:09 UTC 2017


On Tue, 2017-06-06 at 22:00 -0700, Jason Ekstrand wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_context.h       | 1 -
>  src/mesa/drivers/dri/i965/brw_wm.c            | 2 +-
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>  3 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_context.h
> b/src/mesa/drivers/dri/i965/brw_context.h
> index 4c5bc3b..3f4b86a 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.h
> +++ b/src/mesa/drivers/dri/i965/brw_context.h
> @@ -750,7 +750,6 @@ struct brw_context
>     bool has_negative_rhw_bug;
>     bool has_pln;
>     bool no_simd8;
> -   bool use_rep_send;
>  
>     /**
>      * Some versions of Gen hardware don't do centroid interpolation
> correctly
> diff --git a/src/mesa/drivers/dri/i965/brw_wm.c
> b/src/mesa/drivers/dri/i965/brw_wm.c
> index 6fac3c4..7f688e2 100644
> --- a/src/mesa/drivers/dri/i965/brw_wm.c
> +++ b/src/mesa/drivers/dri/i965/brw_wm.c
> @@ -188,7 +188,7 @@ brw_codegen_wm_prog(struct brw_context *brw,
>     program = brw_compile_fs(brw->screen->compiler, brw, mem_ctx,
>                              key, &prog_data, fp->program.nir,
>                              &fp->program, st_index8, st_index16,
> -                            true, brw->use_rep_send, vue_map,
> +                            true, false, vue_map,
>                              &program_size, &error_str);
>  
>     if (program == NULL) {
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index 23358c4..f6b2f17 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -1316,7 +1316,7 @@ genX(upload_clip_state)(struct brw_context
> *brw)
>           clip.ClipMode = CLIPMODE_NORMAL;
>        }
>  
> -      clip.ClipEnable = brw->primitive != _3DPRIM_RECTLIST;
> +      clip.ClipEnable = true;
>  

Is this patch fine? Look like both changes are completely unrelated :-/

Sam

>        /* _NEW_POLYGON,
>         * BRW_NEW_GEOMETRY_PROGRAM | BRW_NEW_TES_PROG_DATA |
> BRW_NEW_PRIMITIVE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170612/114ee6db/attachment-0001.sig>


More information about the mesa-dev mailing list