[Mesa-dev] [PATCH] radv: return correct error on invalid handle from vkAllocateMemory
Dave Airlie
airlied at gmail.com
Mon Jun 12 19:49:17 UTC 2017
From: Dave Airlie <airlied at redhat.com>
Coverity pointed out this was returning uninitialised.
Signed-off-by: Dave Airlie <airlied at redhat.com>
---
src/amd/vulkan/radv_device.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 1ea6960..427d357 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -2108,9 +2108,10 @@ VkResult radv_AllocateMemory(
VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT_KHX);
mem->bo = device->ws->buffer_from_fd(device->ws, import_info->fd,
NULL, NULL);
- if (!mem->bo)
+ if (!mem->bo) {
+ result = VK_ERROR_INVALID_EXTERNAL_HANDLE_KHX;
goto fail;
- else
+ } else
goto out_success;
}
--
2.9.4
More information about the mesa-dev
mailing list