[Mesa-dev] [PATCH] radv: don't shadow meta_va.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Mon Jun 12 20:50:40 UTC 2017


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Mon, Jun 12, 2017 at 9:54 PM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Coverity warned about dead code below, as meta_va was being shadowed.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index 91c7e5f..b08abf7 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -219,7 +219,7 @@ si_set_mutable_tex_desc_fields(struct radv_device *device,
>                 state[6] &= C_008F28_COMPRESSION_EN;
>                 state[7] = 0;
>                 if (image->surface.dcc_size && first_level < image->surface.num_dcc_levels) {
> -                       uint64_t meta_va = gpu_address + image->dcc_offset;
> +                       meta_va = gpu_address + image->dcc_offset;
>                         if (chip_class <= VI)
>                                 meta_va += base_level_info->dcc_offset;
>                         state[6] |= S_008F28_COMPRESSION_EN(1);
> --
> 2.9.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list