[Mesa-dev] [PATCH 00/11] i965: Use BLORP for depth/stencil clears

[Samuel Iglesias Gonsálvez]

On Mon, 2017-06-12 at 13:52 +0200, Samuel Iglesias Gonsálvez wrote:
> On Tue, 2017-06-06 at 21:59 -0700, Jason Ekstrand wrote:
> > This little series switches the GL driver to use BLORP for depth
> > and
> > stencil clears.  BLORP has had depth/stencil clear support ever
> > since
> > we
> > started using it in the Vulkan driver but we didn't hook it up in
> > GL
> > because of a few very hard-to-debug CTS fails.  Patches 10 takes
> > care
> > of
> > those and we now pass except for some weird behavior around
> > occlusion
> > queries on Sandy Bridge.  I'll look into those later.  For now, I
> > think the
> > series is worth reviewing.
> > 
> > Jason Ekstrand (11):
> >   i965/blorp: Set aux_usage to NONE for miplevels without HiZ
> >   mesa: Add a BUFFER_BITS mask for depth+stencil
> >   i965/miptree: Choose the stencil layout in miptree_create_layout
> >   intel/isl: Properly set SeparateStencilBufferEnable on gen5-6
> >   i965: Remove some of the remnants of meta
> >   i965: Remove some unneeded fields from brw_context
> >   i965/blorp: Set no_depth_or_stencil correctly
> >   i965/blorp: Do a depth flush/stall prior to HiZ operations
> >   i965: Disable the interleaved vertex optimization when instancing
> >   i965: Set step_rate == 0 for interleaved vertex buffers
> >   i965: Use blorp for depth/stencil clears on gen6+
> > 
> 
> Patches 2, 3, 6-10 are:
> 
> Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

Patches 1 and 4 are:

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

I am not sure about patch 11 but, as I don't see anything wrong and
assuming Jenkins is happy, then:

Acked-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

Sam


> 
> Sam
> 
> >  src/intel/isl/isl_emit_depth_stencil.c        |  13 ++-
> >  src/mesa/drivers/dri/i965/brw_blorp.c         | 129
> > ++++++++++++++++++++++++++
> >  src/mesa/drivers/dri/i965/brw_blorp.h         |   4 +
> >  src/mesa/drivers/dri/i965/brw_clear.c         |   6 ++
> >  src/mesa/drivers/dri/i965/brw_context.h       |  13 ---
> >  src/mesa/drivers/dri/i965/brw_draw_upload.c   |  12 ++-
> >  src/mesa/drivers/dri/i965/brw_wm.c            |   2 +-
> >  src/mesa/drivers/dri/i965/genX_blorp_exec.c   |   3 +-
> >  src/mesa/drivers/dri/i965/genX_state_upload.c |   2 +-
> >  src/mesa/drivers/dri/i965/intel_mipmap_tree.c |   6 +-
> >  src/mesa/main/mtypes.h                        |   3 +
> >  11 files changed, 167 insertions(+), 26 deletions(-)
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170613/3abbbd9d/attachment.sig>