[Mesa-dev] [PATCH 05/31] mesa: remove update_framebuffer_size

Marek Olšák maraeo at gmail.com
Tue Jun 13 22:00:01 UTC 2017


On Tue, Jun 13, 2017 at 3:46 AM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
> On 13/06/17 02:55, Marek Olšák wrote:
>>
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> For the default framebuffer, _mesa_resize_framebuffer updates it.
>> For FBOs, _mesa_test_framebuffer_completeness updates it.
>>
>> This code is redundant.
>
>
> Everything in the series besides this patch is:
>
> Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
>
> You might want to wait for comment from the Intel devs on the first few
> patches that touch i965 before pushing.
>
> As for this patch, its causing the below tests to fail on the intel drivers:

It's possible that some of the internal i965 compressed texture blits
don't test framebuffer completeness, so fb->Width isn't updated.

Marek


More information about the mesa-dev mailing list