[Mesa-dev] [RFC 02/22] intel/isl: Add ISL <-> DRM modifier conversion

[Daniel Stone]

Hi,

On 14 June 2017 at 07:46, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On June 13, 2017 23:19:28 Chad Versace <chad at kiwitree.net> wrote:
>> This function looks good to me.
>>
>> Alternatively, we could define two orthogonal functions:
>>
>>     bool
>>     isl_tiling_from_drm_format_mod(uint64_t mod, enum isl_tiling *tiling);
>>
>>     bool
>>     isl_aux_usage_from_drm_format_mod(uint64_t mod, enum isl_aux_usage
>> *aux_usage);
>>
>> I'm just thinking out loud, though. Don't interpret that as a suggesting.
>
> I've got an even better plan... While reworking Ben's patches for the CCS
> modifier in the dri driver, I added an isl_drm_modifier_info struct and a
> function to look up the info.  I'm hoping to get those patches sent out this
> week.  I can provide a branch tomorrow.

Ah, missed this reply. I'll leave that in your hands then and wait for
your patches, as well as Chad's ones to update the new protocol in a
few days. Happy to review those when they arrive.

Cheers,
Daniel