[Mesa-dev] [PATCH 08/13] anv: Adjust params of color buffer transitioning functions

Iago Toral itoral at igalia.com
Wed Jun 14 08:13:41 UTC 2017


On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote:
> Splitting out these fields will make the color buffer transitioning
> function simpler when it gains more features.
> 
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/vulkan/anv_blorp.c       | 33 ++++++++++++--------------
> ------
>  src/intel/vulkan/anv_private.h     |  4 ++--
>  src/intel/vulkan/genX_cmd_buffer.c | 39 +++++++++++++++++++++++++---
> ----------
>  3 files changed, 40 insertions(+), 36 deletions(-)
(...)
> @@ -2485,10 +2495,13 @@ cmd_buffer_subpass_transition_layouts(struct
> anv_cmd_buffer * const cmd_buffer,
>                                      image->aspects, target_layout);
>        } else if (image->aspects == VK_IMAGE_ASPECT_COLOR_BIT) {
>           transition_color_buffer(cmd_buffer, image,
> -                                 att_state->current_layout,
> target_layout,
> -                                 &iview->isl, NULL);
> +                                 iview->isl.base_level, 1,
> +                                 iview->isl.base_array_layer,
> +                                 iview->isl.array_len,
> +                                 att_state->current_layout,
> target_layout);
>        }
>  
> +

Unintended blank line I guess...

>        att_state->current_layout = target_layout;
>     }
>  }


More information about the mesa-dev mailing list