[Mesa-dev] [st/va] change va max_entrypoints

Christian König deathsimple at vodafone.de
Wed Jun 14 16:19:43 UTC 2017


Am 14.06.2017 um 17:34 schrieb Emil Velikov:
> On 14 June 2017 at 15:21, Christian König <deathsimple at vodafone.de> wrote:
>> Am 14.06.2017 um 15:40 schrieb Namburu, Chandu-babu:
>>> From: Chandu Babu N <chandu at amd.com>
>>>
>>> As encode support is added along with decode,
>>> now max_entrypoints are two.
>>> vaMaxNumEntrypoints will return correct value.
>>>
>>> Signed-off-by: Chandu Babu N <chandu at amd.com>
>> Reviewed-by: Christian König <christian.koenig at amd.com>
>>
> Gents, can you please add a "Fixes: $sha ..." or "Cc: mesa-stable.." tag.
>
> Having a quick look - seems like the vaQueryConfigEntrypoints()
> callback does not honour the num_entrypoints argument, hence prior to
> this commit we'll be causing memory corruption. We might want to add
> an assert/check or two to prevent this in the future?
>
> -Emil
> P.S. Christian, can I bribe you to use plain text emails - formatting
> goes crazy when trying to reply :-\

Hui? That should already be a plain text mail:

Content-Type: text/plain; charset=windows-1252; format=flowed


And yes CC stable and an assert to check for that sounds like a good 
idea to me as well.

Namburu can you take care of this as well?

Thanks,

Christian.



More information about the mesa-dev mailing list