[Mesa-dev] [PATCH 12/24] cso: don't track the number of sampler states bound

[Marek Olšák]

On Wed, Jun 14, 2017 at 8:03 PM, Marek Olšák <maraeo at gmail.com> wrote:
> On Wed, Jun 14, 2017 at 9:23 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> On 12.06.2017 20:18, Marek Olšák wrote:
>>>
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> This removes 2 loops from hot codepaths and adds 1 loop to a rare codepath
>>> (restore_sampler_states), and makes sanitize_hash() slightly worse.
>>>
>>> Sampler states, when bound, are not unbound for draw calls that don't need
>>> them. That's OK, because bound sampler states don't add any overhead.
>>
>>
>> Is this really always true? They might show up in texture decompression
>> checks.
>
> Sampler states are not sampler views. They don't have any resources
> attached to them.

Also, radeonsi never unbinds sampler states, so this change has no
effect on radeonsi behavior.

Marek