[Mesa-dev] [PATCH 05/11] intel/genxml: Rename StartInstanceLocation to StartingInstanceLocation

[Rafael Antognolli]

Hi Anuj,

On Tue, Jun 13, 2017 at 11:28:24AM -0700, Anuj Phogat wrote:
> This is required because we already have a macro defined with
> the name StartInstanceLocation.
> 
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/intel/genxml/gen10.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen10.xml
> index 06260cf..d2bb130 100644
> --- a/src/intel/genxml/gen10.xml
> +++ b/src/intel/genxml/gen10.xml
> @@ -2570,7 +2570,7 @@
>        <value name="COMP_3" value="3"/>
>      </field>
>      <field name="XP1 Source Select" start="60" end="60" type="uint">
> -      <value name="Start Instance Location" value="1"/>
> +      <value name="Starting Instance Location" value="1"/>

This looks weird since it is the only value in this instruction which
the name doesn't look like a macro (with all caps). But it's not the
first case in all the xml's, so it's probably fine:

Reviewed-by: Rafael Antognolli <rafael.antognolli at intel.com>

>        <value name="XP1_PARAMETER" value="0"/>
>      </field>
>      <field name="XP1 Element Offset" start="48" end="53" type="uint"/>
> -- 
> 2.9.3
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev