[Mesa-dev] [PATCH] anv: FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR not used with VkFormatProperties.bufferFeatures

[Andres Gomez]

On Thu, 2017-06-15 at 01:13 +0100, Lionel Landwerlin wrote:
> Out of curiosity, does this fix a test (maybe upcoming one)?

Not really, but realized checking an upcoming test for vk-gl-cts.

The test was failing on some conditions because of erroneously checking
some FORMAT_FEATURE flags against VkFormatProperties.bufferFeatures.

Upon analysis, I also realized that it should also be failing in a
similar scenario because of checking
FORMAT_FEATURE_TRANSFER_SRC_BIT_KHR against
VkFormatProperties.bufferFeatures. It was not failing when running
against anv due to the bug corrected here.

When this lands, that test will start to (incorrectly) fail also
because of the latter case. That test is also being fixed right now to
check against the proper members of VkFormatProperties and not
bufferFeatures.

Hope this helps to understand where this is all coming from.

-- 
Br,

Andres