[Mesa-dev] [PATCH v1 4/7] gbm: add XBGR8888 support for dumb buffers

[Daniel Stone]

Hi,

On 15 June 2017 at 21:47, Robert Foss <robert.foss at collabora.com> wrote:
> From: Rob Herring <robh at kernel.org>
> diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
> index 19be440d48..58b62ac361 100644
> --- a/src/gbm/backends/dri/gbm_dri.c
> +++ b/src/gbm/backends/dri/gbm_dri.c
> @@ -1067,7 +1067,7 @@ create_dumb(struct gbm_device *gbm,
>     is_cursor = (usage & GBM_BO_USE_CURSOR) != 0 &&
>        format == GBM_FORMAT_ARGB8888;
>     is_scanout = (usage & GBM_BO_USE_SCANOUT) != 0 &&
> -      format == GBM_FORMAT_XRGB8888;
> +      (format == GBM_FORMAT_XRGB8888 || format == GBM_FORMAT_XBGR8888);

Funny, I've just been exactly here myself, cursing at the weird and
asymmetric hardcoded list of formats. Good times.

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel