[Mesa-dev] [PATCH 02/15] i965: Add helper for converting isl tiling to bufmgr tiling

[Nanley Chery]

On Fri, Jun 16, 2017 at 07:58:02AM +0300, Pohjolainen, Topi wrote:
> On Thu, Jun 15, 2017 at 05:18:22PM -0700, Nanley Chery wrote:
> > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote:
> > > Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> > > ---
> > >  src/mesa/drivers/dri/i965/intel_blit.h | 13 +++++++++++++
> > >  1 file changed, 13 insertions(+)
> > > 
> > > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h b/src/mesa/drivers/dri/i965/intel_blit.h
> > > index 2604417e2d..5e4d1f5eb4 100644
> > > --- a/src/mesa/drivers/dri/i965/intel_blit.h
> > > +++ b/src/mesa/drivers/dri/i965/intel_blit.h
> > > @@ -28,6 +28,19 @@
> > >  
> > >  #include "brw_context.h"
> > >  
> > > +static inline unsigned
> > > +isl_tiling_to_bufmgr_tiling(enum isl_tiling tiling)
> > > +{
> > > +   if (tiling == ISL_TILING_X)
> > > +      return I915_TILING_X;
> > > +
> > > +   if (tiling == ISL_TILING_Y0)
> > 
> > I actually just read the patch where this function is used. Don't we
> > also need to return I915_TILING_Y for ISL_TILING_W? Maybe Jason can
> > confirm.
> 
> These values go to brw_bo_alloc_tiled() -> brw_bo_alloc() ->
> bo_alloc_internal() which only understands Y and X. Therefore W is really
> treated as NONE.
> 

Got it.

> > 
> > > +      return I915_TILING_Y;
> > > +
> > > +   /* All other are unknown to buffer allocator. */
> > 
> > It would seem that we'd like to assert for unexpected values instead of
> > failing silently.
> > 
> > > +   return I915_TILING_NONE;
> > > +}
> > > +
> > >  bool
> > >  intelEmitCopyBlit(struct brw_context *brw,
> > >                    GLuint cpp,
> > > -- 
> > > 2.11.0
> > > 
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev