[Mesa-dev] [PATCH] i965: Ignore anisotropic filtering in nearest mode.

Kenneth Graunke kenneth at whitecape.org
Fri Jun 16 21:16:57 UTC 2017


On Friday, June 16, 2017 1:39:47 PM PDT Dylan Baker wrote:
> From: Kenneth Graunke <kenneth at whitecape.org>
> 
> This fixes both Europa Universalis IV and Steallirs rendering on i965.
> This was tested on SKL.
> 
> This fix was discovered by Jakub Szuppe at Stream HPC
> (https://streamhpc.com/).
> 
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96958
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95530
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Tested-by: Dylan Baker <dylan at pnwbakers.com>
> ---
>  src/mesa/drivers/dri/i965/brw_sampler_state.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c b/src/mesa/drivers/dri/i965/brw_sampler_state.c
> index 5d57a35f20..26bf0cb3e2 100644
> --- a/src/mesa/drivers/dri/i965/brw_sampler_state.c
> +++ b/src/mesa/drivers/dri/i965/brw_sampler_state.c
> @@ -450,8 +450,10 @@ brw_update_sampler_state(struct brw_context *brw,
>     /* Enable anisotropic filtering if desired. */
>     unsigned max_anisotropy = BRW_ANISORATIO_2;
>     if (sampler->MaxAnisotropy > 1.0f) {
> -      min_filter = BRW_MAPFILTER_ANISOTROPIC;
> -      mag_filter = BRW_MAPFILTER_ANISOTROPIC;
> +      if (min_filter == BRW_MAPFILTER_LINEAR)
> +         min_filter = BRW_MAPFILTER_ANISOTROPIC;
> +      if (mag_filter == BRW_MAPFILTER_LINEAR)
> +         mag_filter = BRW_MAPFILTER_ANISOTROPIC;
>  
>        if (sampler->MaxAnisotropy > 2.0f) {
>  	 max_anisotropy =
> 

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

(Jason looked at the patch on my monitor and said we could have his R-b.)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170616/fcec7a05/attachment.sig>


More information about the mesa-dev mailing list