[Mesa-dev] [PATCH 1/3] amd/common: fix off-by-one in sid_tables.py

Nicolai Hähnle nhaehnle at gmail.com
Mon Jun 19 11:43:34 UTC 2017


On 19.06.2017 13:36, Emil Velikov wrote:
> Hi Nicolai,
> 
> On 12 June 2017 at 20:33, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>
>> The very last entry in the sid_strings_offsets table ended up missing,
>> leading to out-of-bounds reads and potential crashes.
> 
> Should we have this and " [PATCH 2/3] r600: fix off-by-one in
> egd_tables.py" for -stable?
> Seems like a worthy material IMHO.

Sure, I don't think it hurts. It's only relevant when GALLIUM_DDEBUG is 
used, but there's a small chance it could help some remote debugging in 
the future.

Thanks!
Nicolai

> 
> -Emil
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list