[Mesa-dev] [PATCH V2 1/2] i965: Fix broxton 2x6 l3 config

[Francisco Jerez]

Anuj Phogat <anuj.phogat at gmail.com> writes:

> The new table added in this patch matches with the table
> in gfxspecs. We were programming the wrong values earlier.
>
> V2: Update the comment.
>
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> Cc: Francisco Jerez <currojerez at riseup.net>
> Cc: "17.1" <mesa-stable at lists.freedesktop.org>
> ---
>  src/intel/common/gen_l3_config.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/src/intel/common/gen_l3_config.c b/src/intel/common/gen_l3_config.c
> index ae31d08..44a4b24 100644
> --- a/src/intel/common/gen_l3_config.c
> +++ b/src/intel/common/gen_l3_config.c
> @@ -102,6 +102,20 @@ static const struct gen_l3_config chv_l3_configs[] = {
>  };
>  
>  /**
> + * BXT 2x6 validated L3 configurations.  \sa ivb_l3_configs.
> + */
> +static const struct gen_l3_config bxt_2x6_l3_configs[] = {
> +   /* SLM URB ALL DC  RO  IS   C   T */
> +   {{  0, 32, 48,  0,  0,  0,  0,  0 }},
> +   {{  0, 32,  0,  8, 40,  0,  0,  0 }},
> +   {{  0, 32,  0, 32, 16,  0,  0,  0 }},
> +   {{ 16, 16, 48,  0,  0,  0,  0,  0 }},
> +   {{ 16, 16,  0, 40,  8,  0,  0,  0 }},
> +   {{ 16, 16,  0, 16, 32,  0,  0,  0 }},
> +   {{ 0 }}
> +};
> +
> +/**
>   * Return a zero-terminated array of validated L3 configurations for the
>   * specified device.
>   */
> @@ -117,6 +131,8 @@ get_l3_configs(const struct gen_device_info *devinfo)
>  
>     case 9:
>     case 10:
> +      if (devinfo->gen >= 9 && devinfo->l3_banks == 1)
> +         return bxt_2x6_l3_configs;

The 'devinfo->gen >= 9' check is redundant under this case statement.
With that dropped patch is:

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

>        return chv_l3_configs;
>  
>     default:
> -- 
> 2.9.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170619/4d505da4/attachment.sig>