[Mesa-dev] [PATCH 13/13] anv/gpu_memcpy: Rename the gpu_memcpy function

[Jason Ekstrand]

I'd mildly prefer streamout_memcpy to streamout_cpy.

On Tue, Jun 13, 2017 at 11:42 AM, Nanley Chery <nanleychery at gmail.com>
wrote:

> A GPU memcpy function could alternatively be implemented using MI_*
> commands. Provide more detail into how this one operates in case another
> memcpy function is created.
>
> v2: Update the commit message.
>
> Suggested-by: Jason Ekstrand <jason at jlekstrand.net>
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/vulkan/anv_genX.h        | 8 ++++----
>  src/intel/vulkan/genX_cmd_buffer.c | 6 +++---
>  src/intel/vulkan/genX_gpu_memcpy.c | 8 ++++----
>  3 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_genX.h b/src/intel/vulkan/anv_genX.h
> index 67147b0e92..7b1487b543 100644
> --- a/src/intel/vulkan/anv_genX.h
> +++ b/src/intel/vulkan/anv_genX.h
> @@ -64,10 +64,10 @@ genX(emit_urb_setup)(struct anv_device *device, struct
> anv_batch *batch,
>                       VkShaderStageFlags active_stages,
>                       const unsigned entry_size[4]);
>
> -void genX(cmd_buffer_gpu_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> -                                 struct anv_bo *dst, uint32_t dst_offset,
> -                                 struct anv_bo *src, uint32_t src_offset,
> -                                 uint32_t size);
> +void genX(cmd_buffer_streamout_cpy)(struct anv_cmd_buffer *cmd_buffer,
> +                                    struct anv_bo *dst, uint32_t
> dst_offset,
> +                                    struct anv_bo *src, uint32_t
> src_offset,
> +                                    uint32_t size);
>
>  void genX(blorp_exec)(struct blorp_batch *batch,
>                        const struct blorp_params *params);
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> index 69f1956d4e..8fb1a73b63 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulkan/genX_cmd_buffer.c
> @@ -710,9 +710,9 @@ genX(CmdExecuteCommands)(
>           struct anv_state dst_state = secondary->state.render_pass_
> states;
>           assert(src_state.alloc_size == dst_state.alloc_size);
>
> -         genX(cmd_buffer_gpu_memcpy)(primary, ss_bo, dst_state.offset,
> -                                     ss_bo, src_state.offset,
> -                                     src_state.alloc_size);
> +         genX(cmd_buffer_streamout_cpy)(primary, ss_bo, dst_state.offset,
> +                                        ss_bo, src_state.offset,
> +                                        src_state.alloc_size);
>        }
>
>        anv_cmd_buffer_add_secondary(primary, secondary);
> diff --git a/src/intel/vulkan/genX_gpu_memcpy.c
> b/src/intel/vulkan/genX_gpu_memcpy.c
> index 3cbc7235cf..3f79ff7e7d 100644
> --- a/src/intel/vulkan/genX_gpu_memcpy.c
> +++ b/src/intel/vulkan/genX_gpu_memcpy.c
> @@ -52,10 +52,10 @@ gcd_pow2_u64(uint64_t a, uint64_t b)
>  }
>
>  void
> -genX(cmd_buffer_gpu_memcpy)(struct anv_cmd_buffer *cmd_buffer,
> -                            struct anv_bo *dst, uint32_t dst_offset,
> -                            struct anv_bo *src, uint32_t src_offset,
> -                            uint32_t size)
> +genX(cmd_buffer_streamout_cpy)(struct anv_cmd_buffer *cmd_buffer,
> +                               struct anv_bo *dst, uint32_t dst_offset,
> +                               struct anv_bo *src, uint32_t src_offset,
> +                               uint32_t size)
>  {
>     if (size == 0)
>        return;
> --
> 2.13.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170619/7f46c29b/attachment.html>