[Mesa-dev] [PATCH] egl/android: config id increase one by one

[Liu, Zhiquan]

> -----Original Message-----
> From: Emil Velikov [mailto:emil.l.velikov at gmail.com]
> Sent: Thursday, June 15, 2017 9:59 PM
> To: Liu, Zhiquan <zhiquan.liu at intel.com>
> Cc: ML mesa-dev <mesa-dev at lists.freedesktop.org>; Long, Zhifang
> <zhifang.long at intel.com>; Rob Herring <robh at kernel.org>; Tomasz Figa
> <tfiga at chromium.org>
> Subject: Re: [PATCH] egl/android: config id increase one by one
> 
> On 12 January 2017 at 15:31, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > On 12 January 2017 at 07:38, Liu Zhiquan <zhiquan.liu at intel.com> wrote:
> >> when dri2_add_config, driver_configs may add to exist dri2_conf, the
> >> config id should not increase in this case.
> >> In the code, when ConfigID equal to count+1, it's mean a new config,
> >> config_count will increase. otherwise it's a exist config.
> >>
> > What a lovely little bug. How exactly did you spotted it - please
> > mention in the commit log.
> >
> >> Signed-off-by: Liu Zhiquan <zhiquan.liu at intel.com>
> >> Signed-off-by: Long, Zhifang <zhifang.long at intel.com>
> >> ---
> >>  src/egl/drivers/dri2/platform_android.c | 11 ++++++-----
> >>  1 file changed, 6 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/src/egl/drivers/dri2/platform_android.c
> >> b/src/egl/drivers/dri2/platform_android.c
> >> index 1c880f9..5bf6fd5 100644
> >> --- a/src/egl/drivers/dri2/platform_android.c
> >> +++ b/src/egl/drivers/dri2/platform_android.c
> >> @@ -950,9 +950,9 @@ droid_add_configs_for_visuals(_EGLDriver *drv,
> _EGLDisplay *dpy)
> >>       EGL_NONE
> >>     };
> >>     unsigned int format_count[ARRAY_SIZE(visuals)] = { 0 };
> >> -   int count, i, j;
> >> +   int config_count, i, j;
> >>
> > Please keep the variable name as-is. With that the patch is
> > Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> >
> > Other platforms would need similar fix, can you please send patches
> > for those as well please ?
> >
> Humble poke - any update?
I find eric at engestrom.ch have made a patch (egl: properly count configs) to complete this patch. Please review that one.