[Mesa-dev] [PATCH 1/3] glsl: fix typo in comment

Lionel Landwerlin lionel.g.landwerlin at intel.com
Wed Jun 21 10:31:07 UTC 2017


Patches 1 & 2 are :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 21/06/17 11:12, Timothy Arceri wrote:
> ---
>   src/compiler/glsl/opt_algebraic.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compiler/glsl/opt_algebraic.cpp b/src/compiler/glsl/opt_algebraic.cpp
> index a5ba843..a5a1029 100644
> --- a/src/compiler/glsl/opt_algebraic.cpp
> +++ b/src/compiler/glsl/opt_algebraic.cpp
> @@ -239,21 +239,21 @@ ir_algebraic_visitor::reassociate_operands(ir_expression *ir1,
>       * binops is still a vector if any of them were.
>       */
>      update_type(ir2);
>   
>      this->progress = true;
>   }
>   
>   /**
>    * Reassociates a constant down a tree of adds or multiplies.
>    *
> - * Consider (2 * (a * (b * 0.5))).  We want to send up with a * b.
> + * Consider (2 * (a * (b * 0.5))).  We want to end up with a * b.
>    */
>   bool
>   ir_algebraic_visitor::reassociate_constant(ir_expression *ir1, int const_index,
>   					   ir_constant *constant,
>   					   ir_expression *ir2)
>   {
>      if (!ir2 || ir1->operation != ir2->operation)
>         return false;
>   
>      /* Don't want to even think about matrices. */




More information about the mesa-dev mailing list