[Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

[Nicolai Hähnle]

On 21.06.2017 00:54, Marek Olšák wrote:
> Hi,
> 
> This series updates pipe loaders so that flags such as drirc options
> can be passed to create_screen(). I have compile-tested everything
> except clover.
> 
> The first pipe_screen flag is a drirc option to fix incorrect grass
> rendering in Rocket League for radeonsi. Rocket League expects DirectX
> behavior for partial derivative computations after discard/kill, but
> radeonsi implements the more efficient but stricter OpenGL behavior
> and that will remain our default behavior. The new screen flag forces
> radeonsi to use the DX behavior for that game.
> 
> Please review.

Makes sense.

The one thing I don't particularly like about this series is that it 
forces drirc through flags that are defined at the Gallium API level. 
There may be an opportunity for drirc options that have numeric values, 
for example to change hardware-specific texture sampling quality 
settings. But maybe that's a bridge to be crossed when we get there.

Series is:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>


> 
> Thanks,
> Marek
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.