[Mesa-dev] [PATCH 2/4] mesa: remove spurious flush in _mesa_Viewport()

[Brian Paul]

On 06/22/2017 08:35 AM, Samuel Pitoiset wrote:
> I don't think this is actually required, if the viewport
> values are different from the ones stored in the context, we
> already flush and trigger _NEW_VIEWPORT in
> set_viewport_no_notify().
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/mesa/main/viewport.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c
> index a4097efd6f0..2b3d1556d91 100644
> --- a/src/mesa/main/viewport.c
> +++ b/src/mesa/main/viewport.c
> @@ -97,7 +97,6 @@ _mesa_Viewport(GLint x, GLint y, GLsizei width, GLsizei height)
>   {
>      unsigned i;
>      GET_CURRENT_CONTEXT(ctx);
> -   FLUSH_VERTICES(ctx, 0);
>
>      if (MESA_VERBOSE & VERBOSE_API)
>         _mesa_debug(ctx, "glViewport %d %d %d %d\n", x, y, width, height);
>

Reviewed-by: Brian Paul <brianp at vmware.com>