[Mesa-dev] [PATCH v4 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

[Emil Velikov]

Hi Gert,

On 21 June 2017 at 13:59, Gert Wollny <gw.fossdev at gmail.com> wrote:
> This patch adds a set of unit tests for the new lifetime tracker.
> ---
>  configure.ac                                       |   1 +
>  src/mesa/Makefile.am                               |   2 +-
>  src/mesa/state_tracker/tests/Makefile.am           |  40 +
>  .../tests/test_glsl_to_tgsi_lifetime.cpp           | 976 +++++++++++++++++++++
>  4 files changed, 1018 insertions(+), 1 deletion(-)
>  create mode 100644 src/mesa/state_tracker/tests/Makefile.am
>  create mode 100644 src/mesa/state_tracker/tests/test_glsl_to_tgsi_lifetime.cpp
>
> diff --git a/configure.ac b/configure.ac
> index da7b2f8f81..5279b231ed 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2839,6 +2839,7 @@ AC_CONFIG_FILES([Makefile
>                 src/mesa/drivers/osmesa/osmesa.pc
>                 src/mesa/drivers/x11/Makefile
>                 src/mesa/main/tests/Makefile
> +               src/mesa/state_tracker/tests/Makefile
>                 src/util/Makefile
>                 src/util/tests/hash_table/Makefile
>                 src/vulkan/Makefile])
> diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am
> index 53f311d2a9..a88a94165d 100644
> --- a/src/mesa/Makefile.am
> +++ b/src/mesa/Makefile.am
> @@ -19,7 +19,7 @@
>  # FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>  # IN THE SOFTWARE.
>
> -SUBDIRS = . main/tests
> +SUBDIRS = . main/tests state_tracker/tests
>
>  if HAVE_XLIB_GLX
>  SUBDIRS += drivers/x11
> diff --git a/src/mesa/state_tracker/tests/Makefile.am b/src/mesa/state_tracker/tests/Makefile.am
> new file mode 100644
> index 0000000000..361ef5cfb7
> --- /dev/null
> +++ b/src/mesa/state_tracker/tests/Makefile.am
> @@ -0,0 +1,40 @@
> +AM_CFLAGS = \
> +       $(PTHREAD_CFLAGS)
> +
> +AM_CXXFLAGS = \
> +       $(LLVM_CXXFLAGS)
> +
> +AM_CPPFLAGS = \
> +       -I$(top_srcdir)/src/gtest/include \
> +       -I$(top_srcdir)/src \
> +       -I$(top_srcdir)/src/mapi \
> +       -I$(top_builddir)/src/mesa \
> +       -I$(top_srcdir)/src/mesa \
> +       -I$(top_srcdir)/include \
> +       -I$(top_srcdir)/src/gallium/include \
> +       -I$(top_srcdir)/src/gallium/auxiliary \
> +       $(DEFINES) $(INCLUDE_DIRS)
INCLUDE_DIRS is/should be undefined in here - please drop.

> +
> +TESTS = st-renumerate-test
> +check_PROGRAMS = st-renumerate-test
> +
> +st_renumerate_test_SOURCES =                   \
> +       test_glsl_to_tgsi_lifetime.cpp
> +
> +st_renumerate_test_LDFLAGS = \
> +       $(LLVM_LDFLAGS)
> +
> +st_renumerate_test_LDADD = \
> +       $(top_builddir)/src/mesa/libmesagallium.la \
> +       $(top_builddir)/src/mapi/shared-glapi/libglapi.la \
> +       $(top_builddir)/src/gallium/auxiliary/libgallium.la \
> +       $(top_builddir)/src/util/libmesautil.la \
> +       $(top_builddir)/src/gallium/drivers/trace/libtrace.la \
> +       $(top_builddir)/src/gallium/winsys/sw/null/libws_null.la \
> +       $(top_builddir)/src/gallium/drivers/softpipe/libsoftpipe.la \
> +       $(top_builddir)/src/gtest/libgtest.la \
> +       $(GALLIUM_COMMON_LIB_DEPS) \
> +       $(LLVM_LIBS) \
> +       $(PTHREAD_LIBS) \
> +       $(DLOPEN_LIBS)
> +
I'm a bit suspicious if we need all of the above list.

In particular - glapi, trace, winsys/sw and drivers/softpipe.
Please check those and drop if not applicable.

With that from build POV the patch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks
Emil