[Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee Lake.

[Srivatsa, Anusha]

>-----Original Message-----
>From: Anuj Phogat [mailto:anuj.phogat at gmail.com]
>Sent: Thursday, June 22, 2017 10:54 AM
>To: Srivatsa, Anusha <anusha.srivatsa at intel.com>
>Cc: mesa-dev at lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi at intel.com>;
>Phogat, Anuj <anuj.phogat at intel.com>; Widawsky, Benjamin
><benjamin.widawsky at intel.com>
>Subject: Re: [Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee Lake.
>
>On Thu, Jun 22, 2017 at 10:42 AM, Anusha Srivatsa <anusha.srivatsa at intel.com>
>wrote:
>> Coffee Lake has a gen9 graphics following KBL.
>> From 3D perspective, CFL is a clone of KBL/SKL features.
>>
>> v2: Change commit message, correct alignment <Anuj Phogat>
>> v3: Update IDs.
>> v4: Initialize l3_banks, correct nomenclature <Anuj>
>>
>> Cc: Benjamin Widawsky <benjamin.widawsky at intel.com>
>> Cc: Anuj Phogat <anuj.phogat at intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
>> ---
>>  include/pci_ids/i965_pci_ids.h     | 11 +++++++++++
>>  src/intel/common/gen_device_info.c | 26 ++++++++++++++++++++++++++
>> src/intel/common/gen_device_info.h |  1 +
>>  3 files changed, 38 insertions(+)
>>
>> diff --git a/include/pci_ids/i965_pci_ids.h
>> b/include/pci_ids/i965_pci_ids.h index b296359..57e70b7 100644
>> --- a/include/pci_ids/i965_pci_ids.h
>> +++ b/include/pci_ids/i965_pci_ids.h
>> @@ -165,6 +165,17 @@ CHIPSET(0x5927, kbl_gt3, "Intel(R) Iris Plus
>> Graphics 650 (Kaby Lake GT3)")  CHIPSET(0x593B, kbl_gt4, "Intel(R) Kabylake
>GT4")
>>  CHIPSET(0x3184, glk,     "Intel(R) HD Graphics (Geminilake)")
>>  CHIPSET(0x3185, glk_2x6, "Intel(R) HD Graphics (Geminilake 2x6)")
>> +CHIPSET(0x3E90, cfl_gt1, "Intel(R) HD Graphics (Coffeelake 2x6 GT1)")
>> +CHIPSET(0x3E93, cfl_gt1, "Intel(R) HD Graphics (Coffeelake 2x6 GT1)")
>> +CHIPSET(0x3E91, cfl_gt2, "Intel(R) HD Graphics (Coffeelake 3x8 GT2)")
>> +CHIPSET(0x3E92, cfl_gt2, "Intel(R) HD Graphics (Coffeelake 3x8 GT2)")
>> +CHIPSET(0x3E96, cfl_gt2, "Intel(R) HD Graphics (Coffeelake 3x8 GT2)")
>> +CHIPSET(0x3E9B, cfl_gt2, "Intel(R) HD Graphics (Coffeelake 3x8 GT2)")
>> +CHIPSET(0x3E94, cfl_gt2, "Intel(R) HD Graphics (Coffeelake 3x8 GT2)")
>> +CHIPSET(0x3EA6, cfl_gt3, "Intel(R) HD Graphics (Coffeelake 3x8 GT3)")
>> +CHIPSET(0x3EA7, cfl_gt3, "Intel(R) HD Graphics (Coffeelake 3x8 GT3)")
>> +CHIPSET(0x3EA8, cfl_gt3, "Intel(R) HD Graphics (Coffeelake 3x8 GT3)")
>> +CHIPSET(0x3EA5, cfl_gt3, "Intel(R) HD Graphics (Coffeelake 3x8 GT3)")
>>  CHIPSET(0x5A49, cnl_2x8, "Intel(R) HD Graphics (Cannonlake 2x8
>> GT0.5)")  CHIPSET(0x5A4A, cnl_2x8, "Intel(R) HD Graphics (Cannonlake
>> 2x8 GT0.5)")  CHIPSET(0x5A41, cnl_3x8, "Intel(R) HD Graphics
>> (Cannonlake 3x8 GT1)") diff --git a/src/intel/common/gen_device_info.c
>> b/src/intel/common/gen_device_info.c
>> index 423748e..a1541ed 100644
>> --- a/src/intel/common/gen_device_info.c
>> +++ b/src/intel/common/gen_device_info.c
>> @@ -607,6 +607,32 @@ static const struct gen_device_info
>gen_device_info_glk_2x6 = {
>>     .is_geminilake = true,
>>  };
>>
>> +static const struct gen_device_info gen_device_info_cfl_gt1 = {
>> +   GEN9_FEATURES,
>> +   .is_coffeelake = true,
>> +   .gt = 1,
>> +   .l3_banks = 2,
>> +
>> +   .num_slices = 1,
>I'll omit the blank line and move l3_banks after num_slices just for consistency.
>You need not send out another version for this.

Thanks Anuj.

Anusha 
>> +};
>> +static const struct gen_device_info gen_device_info_cfl_gt2 = {
>> +   GEN9_FEATURES,
>> +   .is_coffeelake = true,
>> +   .gt = 2,
>> +   .l3_banks = 4,
>> +
>> +   .num_slices = 1,
>> +};
>> +
>> +static const struct gen_device_info gen_device_info_cfl_gt3 = {
>> +   GEN9_FEATURES,
>> +   .is_coffeelake = true,
>> +   .gt = 3,
>> +   .l3_banks = 8,
>> +
>> +   .num_slices = 2,
>> +};
>> +
>>  #define GEN10_HW_INFO                               \
>>     .gen = 10,                                       \
>>     .num_thread_per_eu = 7,                          \
>> diff --git a/src/intel/common/gen_device_info.h
>> b/src/intel/common/gen_device_info.h
>> index cc83857..a83251c 100644
>> --- a/src/intel/common/gen_device_info.h
>> +++ b/src/intel/common/gen_device_info.h
>> @@ -46,6 +46,7 @@ struct gen_device_info
>>     bool is_broxton;
>>     bool is_kabylake;
>>     bool is_geminilake;
>> +   bool is_coffeelake;
>>     bool is_cannonlake;
>>
>>     bool has_hiz_and_separate_stencil;
>> --
>> 2.7.4
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
>
>I'll push the patch upstream for you. Thanks.