[Mesa-dev] [PATCH 2/8] mesa: add KHR_no_error support for glClipControl()

[Timothy Arceri]

On 23/06/17 00:36, Samuel Pitoiset wrote:
> ---
>   src/mapi/glapi/gen/ARB_clip_control.xml | 2 +-
>   src/mesa/main/viewport.c                | 9 +++++++++
>   src/mesa/main/viewport.h                | 3 +++
>   3 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mapi/glapi/gen/ARB_clip_control.xml b/src/mapi/glapi/gen/ARB_clip_control.xml
> index ecce133bb99..051a648081f 100644
> --- a/src/mapi/glapi/gen/ARB_clip_control.xml
> +++ b/src/mapi/glapi/gen/ARB_clip_control.xml
> @@ -14,7 +14,7 @@
>       <enum name="CLIP_ORIGIN" value = "0x935C"/>
>       <enum name="CLIP_DEPTH_MODE" value = "0x935D"/>
>   
> -    <function name="ClipControl">
> +    <function name="ClipControl" no_error="true">
>           <param name="origin" type="GLenum"/>
>           <param name="depth" type="GLenum"/>
>           <!-- <glx rop="1340"/> -->
> diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c
> index cf91dd284cb..2fbb16d6227 100644
> --- a/src/mesa/main/viewport.c
> +++ b/src/mesa/main/viewport.c
> @@ -444,6 +444,15 @@ clip_control(struct gl_context *ctx, GLenum origin, GLenum depth)
>   
>   
>   void GLAPIENTRY
> +_mesa_ClipControl_no_error(GLenum origin, GLenum depth)
> +{
> +   GET_CURRENT_CONTEXT(ctx);
> +   clip_control(ctx, origin, depth);
> +

Please remove the extra space above. Otherwise, series:

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

> +}
> +
> +
> +void GLAPIENTRY
>   _mesa_ClipControl(GLenum origin, GLenum depth)
>   {
>      GET_CURRENT_CONTEXT(ctx);
> diff --git a/src/mesa/main/viewport.h b/src/mesa/main/viewport.h
> index 395131982cf..88757f0291e 100644
> --- a/src/mesa/main/viewport.h
> +++ b/src/mesa/main/viewport.h
> @@ -74,6 +74,9 @@ extern void
>   _mesa_init_viewport(struct gl_context *ctx);
>   
>   
> +void GLAPIENTRY
> +_mesa_ClipControl_no_error(GLenum origin, GLenum depth);
> +
>   extern void GLAPIENTRY
>   _mesa_ClipControl(GLenum origin, GLenum depth);
>   
>