[Mesa-dev] [PATCH] st/dri2: implement image offset query

[Daniel Stone]

On 23 June 2017 at 16:58, Lucas Stach <l.stach at pengutronix.de> wrote:
> Am Freitag, den 23.06.2017, 16:54 +0100 schrieb Daniel Stone:
>> On 23 June 2017 at 16:36, Lucas Stach <l.stach at pengutronix.de> wrote:
>> > This trivially adds support for the image offset query, which is needed
>> > for the zwp_linux_dmabuf based EGL platform wayland implementation.
>> >
>> > Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
>>
>> So, whilst the patch is mostly good, it will break VC4 in the
>> meantime, as it doesn't bother setting the handle to 0 in
>> resource_get_handle(). Same with Freedreno, VirGL and at least some
>> others. I'll just change the offset query in the new dmabuf path for
>> egl/wayland to handle failure.
>
> Nope, dri2_query_image() memsets the handle to 0 before calling into the
> driver. So all drivers leaving offset unchanged on resource_get_handle
> are fine.

Right you are; apparently I can't read.

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel