[Mesa-dev] [PATCH 1/2] spirv: Fix reaching unreachable for compare exchange on images

James Legg jlegg at feralinteractive.com
Mon Jun 26 09:44:52 UTC 2017


On Fri, 2017-06-23 at 11:29 -0700, Jason Ekstrand wrote:
> OpAtomicCompareExchangeWeak is only available in OpenCL, not Vulkan. 
> As such, we probably don't want to handle it yet as no one uses
> spirv_to_nir for OpenCL.  The assert on AtomicCompareExchange is,
> however, a bug we should fix now.

I'll drop the OpAtomicCompareExchangeWeak changes. It is still
partially handled elsewhere in spirv_to_nir.c, however each case would
fail the assertion in fill_common_atomic_sources.

Thanks,
James


More information about the mesa-dev mailing list